cpputest: fixed wrap #1398
cpputest: fixed wrap #1398
Conversation
|
Any suggestions how could i keep the extensions off by default while keeping the CI green? Not even necessarily for this case, just curious. |
|
You can specify build options in |
SteelPh0enix
force-pushed
the
cpputest
branch
from
bfb567c
to
9ae8f9a
Compare
SteelPh0enix
force-pushed
the
cpputest
branch
from
9ae8f9a
to
9cee674
Compare
|
I've added CI settings, fixed some stuff and performed sanity checks locally, it should be green now. |
|
Huh, so that's how this switch works... All right, i'll make a compiler check in there for MSVC and GCC/Clang, should be good enough for the CI and "most people". |
|
Done, hopefully that's the last issue |
| @@ -3,7 +3,7 @@ cpputest_platform = get_option('cpputest_platform') | |||
| if cpputest_platform != 'none' | |||
| if cpputest_platform == 'autodetect' | |||
| compiler_id = meson.get_compiler('cpp').get_id() | |||
| if compiler_id == 'clang' or compiler_id == 'gcc' | |||
| if compiler_id == 'gcc' or compiler_id == 'clang' or compiler_id == 'clang-cl' | |||
There was a problem hiding this comment.
should it be treated as GCC or VisualCpp?
There was a problem hiding this comment.
Yeah, it passes here so I'm not sure if it's just a funky compatibility layer, or intended behaviour.
I'll throw it to VisualCpp and let's see what happens
There was a problem hiding this comment.
After quick read, yeah, this should definitely be treated as VisualCpp
* Updated wrap files for cpputest-4.0 * Renamed meson.options to meson_options.txt * Added build options for cpputest * Added extensions to deps in releases.json and fixed build options * Merged extensions into main CppUTest dep + fixed CI config * Removed CppUTestExt from releases.json as it's now a single dependency * Typo fixes * Renamed options + added simple platform autodetection * Removed unnecessary "build_on" from ci_config * Added clang-cl to autodetection * Moved clang-cl to VisualCpp
* Updated wrap files for cpputest-4.0 * Renamed meson.options to meson_options.txt * Added build options for cpputest * Added extensions to deps in releases.json and fixed build options * Merged extensions into main CppUTest dep + fixed CI config * Removed CppUTestExt from releases.json as it's now a single dependency * Typo fixes * Renamed options + added simple platform autodetection * Removed unnecessary "build_on" from ci_config * Added clang-cl to autodetection * Moved clang-cl to VisualCpp
Current wrap of CppUTest is fundamentally broken in multiple ways:
This PR fixes all those issues and makes this wrap usable.