Merge pull request #535 from carroux/periods_in_job_names

Allow periods in job names
mesos · Sep 10, 2015 · dded172 · dded172
2 parents 9de3529 + ad1a530
commit dded172
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/main/scala/org/apache/mesos/chronos/scheduler/jobs/JobUtils.scala b/src/main/scala/org/apache/mesos/chronos/scheduler/jobs/JobUtils.scala
@@ -19,7 +19,7 @@ import scala.collection.mutable.ListBuffer
  */
 object JobUtils {
 
-  val jobNamePattern = """([\w\s#_-]+)""".r
+  val jobNamePattern = """([\w\s\.#_-]+)""".r
   val stats = new mutable.HashMap[String, DescriptiveStatistics]()
   val maxValues = 100
   //The object mapper, which is, according to the docs, Threadsafe once configured.

diff --git a/src/test/scala/org/apache/mesos/chronos/scheduler/jobs/JobUtilsSpec.scala b/src/test/scala/org/apache/mesos/chronos/scheduler/jobs/JobUtilsSpec.scala
@@ -64,4 +64,10 @@ class JobUtilsSpec extends SpecificationWithJUnit with Mockito {
     scheduledJobWithArguments.command.toString must_== commandWithArguments
     dependencyJobWithArguments.command.toString must_== commandWithArguments
   }
+
+  "Accepts a job name with periods" in {
+    val jobName = "sample.name"
+
+    JobUtils.isValidJobName(jobName)
+  }
 }