Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept offers with role '*' with --mesos_role #462

Merged
merged 1 commit into from
Jun 4, 2015

Conversation

felixb
Copy link
Contributor

@felixb felixb commented Jun 3, 2015

Chronos should accept offers for role '' when running with a role other than ''.

@elingg
Copy link
Member

elingg commented Jun 3, 2015

LGTM, I'm not sure what changed, but I do see that Marathon also has code with r.getRole == "*". Let me know if there are any further objections.

@modeyang
Copy link

modeyang commented Jun 4, 2015

LGTM, I also confronted that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants