Fix JVM crashes when the hostname is not resolvable #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,8 +37,8 @@ trait SchedulerConfiguration extends ScallopConf { | |||
| descr = "The list of ZooKeeper servers for storing state", | |||
| default = Some("localhost:2181")) | |||
| lazy val hostname = opt[String]("hostname", | |||
| descr = "The advertised hostname stored in ZooKeeper so another standby " + | |||
| "host can redirect to this elected leader", | |||
| descr = "The advertised hostname, stored in ZooKeeper so another standby " + | |||
There was a problem hiding this comment.
My proposal:
"The advertised hostname of this Chronos instance for network communication. This is used by other Chronos instances and the Mesos master."
gkleiman
force-pushed
the
gk/set_hostname
branch
from
0fb5c64
to
912408f
Compare
Due to a bug in Mesos < 0.24.0, Marathon users have observed JVM crashes when the framework the host's hostname is nor resolvable (https://issues.apache.org/jira/browse/MESOS-3145). This change works around the problem by setting the hostname in the Framework Information proto.
gkleiman
force-pushed
the
gk/set_hostname
branch
from
912408f
to
573b17c
Compare
kolloch
pushed a commit
that referenced
this pull request
Aug 18, 2015
Set the hostname in the framework information proto
|
I feel blown away... 👍 |
gkleiman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in Mesos < 0.24.0, Marathon users have observed JVM crashes
when the framework the host's hostname is nor resolvable
(https://issues.apache.org/jira/browse/MESOS-3145).
This change works around the problem by setting the hostname in the
Framework Information proto.