Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Sender API support, updated example-executor #325

Merged
merged 10 commits into from
Sep 18, 2017
Merged

executor: Sender API support, updated example-executor #325

merged 10 commits into from
Sep 18, 2017

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Sep 18, 2017

fixes #317

@jdef jdef added the api/v1 label Sep 18, 2017
@coveralls
Copy link

coveralls commented Sep 18, 2017 •
edited

Coverage Status

Coverage increased (+0.8%) to 58.337% when pulling 5798ac9 on jdef_executor_sender into 7a9076f on master.

@coveralls
Copy link

coveralls commented Sep 18, 2017 •
edited

Coverage Status

Coverage increased (+0.8%) to 58.337% when pulling 2b79cc3 on jdef_executor_sender into 7a9076f on master.

janisz
janisz reviewed Sep 18, 2017
View reviewed changes
api/v1/cmd/example-executor/main.go
} else {
call.Subscribe.UnacknowledgedTasks = nil
// unacknowledgedTasks generates the value of the UnacknowledgedTasks field of a Subscribe call.
func unacknowledgedTasks(state *internalState) (result []mesos.TaskInfo) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unacknowledgedTasks should be a function on *internalState but it's a minor issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way. Maybe tackle in a follow-up PR

@jdef jdef merged commit 562dd0e into master Sep 18, 2017
@jdef jdef deleted the jdef_executor_sender branch September 18, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz left review comments

Assignees
No one assigned
Labels
api/v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add api/v1/lib/executor/calls Sender API
3 participants
@jdef @coveralls @janisz