Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support masters on ipv6 #328

Closed
wants to merge 5 commits into from

Conversation

drewkerrigan
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 26, 2017

Coverage Status

Coverage remained the same at 58.337% when pulling 94a95d2 on drewkerrigan:ack/ipv6 into befca3f on mesos:master.

Copy link
Contributor

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! has this seen any integration testing yet?

// The cross-compiled version of net.LookupIP() fails to handle plain IPs.
// See https://github.com/mesos/mesos-go/pull/117
} else if ip = parsedIP.To16(); ip != nil {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// ditto ?

@jdef jdef added the PTAL label Oct 23, 2017
@jdef
Copy link
Contributor

jdef commented Mar 6, 2018

abandoned, closing this out. please re-open if/when needed

@jdef jdef closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants