Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: allow ReservationInfo.Type to be nil #341

Merged

Conversation

ajwerner
Copy link
Contributor

This is to address incompatibility with Mesos 1.4 agent reservations as described in #340

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.39% when pulling 8e9f780 on ajwerner:andrew/allow_reservation_info_type_to_be_nil into c488712 on mesos:master.

@jdef
Copy link
Contributor

jdef commented Jan 19, 2018

thanks for the PR! it looks like the gogo protobuf generation tools are out-of-sync w/ the version of the gogo tooling that's been vendored by the project. please see the travis config for how to install the right version of the tooling and then please re-generate the protos.

- api/v1/vendor/github.com/gogo/protobuf/install-protobuf.sh

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage remained the same at 58.39% when pulling 180ac5c on ajwerner:andrew/allow_reservation_info_type_to_be_nil into c488712 on mesos:master.

@ajwerner
Copy link
Contributor Author

Should be good to go

@jdef jdef merged commit fa6a976 into mesos:master Jan 19, 2018
@jdef
Copy link
Contributor

jdef commented Jan 19, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants