Remove try/catch block that can't be hit. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateiz
added a commit
that referenced
this pull request
Mar 20, 2013
Remove try/catch block that can't be hit.
|
Good idea, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change, but like the code from the StandaloneExecutorBackend.preStart that was fixed a few weeks ago, all of these method calls are async, and so will not cause connection/etc. exceptions.
Granted, this is not causing any bugs, but it can lure the programmer into thinking the calls are sync (it did me anyway) and so lead to seemingly-surprising behavior.
It seems simpler to just take it out, so it mirrors what StandaloneExecutorBackend.preStart looks like now.