Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport fixes for CI builds to storm-0.x branch #210

Merged
merged 3 commits into from
Aug 16, 2017
Merged

backport fixes for CI builds to storm-0.x branch #210

merged 3 commits into from
Aug 16, 2017

Conversation

erikdw
Copy link
Collaborator

@erikdw erikdw commented Aug 16, 2017

Ran these commands:

% git checkout storm-0.x
% git cherry-pick b3d3b02ab1349edd56aaf25af77fd580bb93fa0f b78aad789c52e5a5e4487488c7d061c331cdf9e4 8de8a75f856b850675299e8479da483e1607d20d
% git push origin storm-0.x
# Where the push remote for origin was erikdw/storm-mesos

@erikdw
Copy link
Collaborator Author

erikdw commented Aug 16, 2017

@JessicaLHartog & @changreytang : please 👁

JessicaLHartog
JessicaLHartog reviewed Aug 16, 2017
View reviewed changes
Copy link
Collaborator

@JessicaLHartog JessicaLHartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Looks good!

changreytang
changreytang approved these changes Aug 16, 2017
View reviewed changes
Copy link
Collaborator

@changreytang changreytang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@erikdw erikdw merged commit a8b696f into mesos:storm-0.x Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaLHartog JessicaLHartog JessicaLHartog left review comments

@changreytang changreytang changreytang approved these changes

Assignees

@JessicaLHartog JessicaLHartog

Labels
backport build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikdw @JessicaLHartog @changreytang