Use storm.local.dir for generated-conf path.
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brndnmtthws
force-pushed
the
prefix-generated-conf-dir
branch
3 times, most recently
from
b12560a
to
64cc591
Compare
| Optional.fromNullable((String) conf.get(Config.STORM_LOCAL_DIR)).or("./"), | ||
| "generated-conf"); | ||
| if (!_generatedConfPath.toFile().exists() && !_generatedConfPath.toFile().mkdirs()) { | ||
| throw new RuntimeException("Couldn't create generated-conf dir"); |
There was a problem hiding this comment.
nice, you fixed that greate typo ;)
There was a problem hiding this comment.
Maybe add in the path that couldn't be created to the exception? _generatedConfPath
There was a problem hiding this comment.
Thanks for always being so quick!
brndnmtthws
force-pushed
the
prefix-generated-conf-dir
branch
from
64cc591
to
3d504b0
Compare
|
@brndnmtthws : looks good, I think this is an improvement, but perhaps we should wait for @salimane to test it to ensure it actually fixes his issue in #70. |
|
@brndnmtthws @erikdw everything looks good, tested it and it works 👍 |
|
thanks @brndnmtthws & @salimane ! 🚢 🇮🇹 ! |
brndnmtthws
added a commit
that referenced
this pull request
Dec 1, 2015
Use `storm.local.dir` for generated-conf path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to address #70.