Setting log_format to the same as marathon-framework

[sjoerdmulder]

Making the log_format of both marathon and chronos consistent. See: https://github.com/mesosphere/marathon/blob/515f04b2b741a5c7dee36515c893b4cc267a9ed0/bin/marathon-framework#L95

[lloesche]

Thanks for the PR @sjoerdmulder !

I see where you're coming from. I just think it's too late to change it now. Both Marathon and Chronos are in wide use and I'm not willing to break peoples existing log parsers for the sake of uniformity. As much as this triggers my OCD now that I know 😄

@lingmann Thoughts?

[lingmann]

I tend to agree. How about making the log format user configurable via config file / environment variable? That way we could have an easy path to deprecate the old format.

[lloesche]

I like it, we could do something like

local log_format="${LOG_FORMAT:-%2\$s %5\$s%6\$s%n}"

then users can provide LOG_FORMAT via /etc/sysconfig/chronos or some other way that sets the env var.

@sjoerdmulder would you mind updating the PR?

[sjoerdmulder]

Yes off course, actually the space is causing issues for me with passing
extra args. Hence the PR.
Op 6 jun. 2016 18:41 schreef "Lukas Lösche" notifications@github.com:

I just realised why log_format was assigned in single quotes.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAOY4Ru5sZOacpkdAUyyFE_lSifscyd7ks5qJE3EgaJpZM4IFFJH
.

[lloesche]

Closing for inactivity. Please open a new PR if you plan on implementing the suggested change.