Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFINITY-3491/3495 Fix invalid reservation handling, add hello-world examples #2462

Merged
merged 4 commits into from Apr 6, 2018

Conversation

nickbp
Copy link
Contributor

@nickbp nickbp commented Apr 5, 2018

Fixes:

  • When in multi-service mode, we would previously clean reservations that lacked a service name label. Instead, just complain and leave them be.
  • CuratorLocker had again started getting invoked after other access had already happened. Fix the problem once and for all by moving locking immediately before building the CuratorPersister object itself.
  • Other fixes from INFINITY-3472/3475 Finish first draft of multi-service support #2460

New:

  • Updates hello-world to include a reference implementation of running a 'dynamic' multi-service scheduler, as well as a 'static' multi-service scheduler, in addition to the current single-service options. Dynamic mode is run when no yaml files are provided, while static is run when multiple (comma or space-separated) yaml files are provided. Next is to add integration tests against this implementation (JIRA filed)

"default": "YAML"
},
"yaml": {
"description": "An example YAML file to deploy",
"description": "Comma-separated list of zero or more example YAML files to deploy",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add another field yamls for this.

@nickbp nickbp merged commit 24d8077 into master Apr 6, 2018
@nickbp nickbp deleted the multi-fixes branch April 6, 2018 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants