Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add high priority for cert-manager external-dns #1242

Merged
merged 2 commits into from
May 18, 2023

Conversation

sonofgibs
Copy link
Contributor

What problem does this PR solve?:
Update app configs to use DKP High PriorityClass for tools apps

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-96663

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@sonofgibs sonofgibs added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing labels May 11, 2023
@sonofgibs sonofgibs self-assigned this May 11, 2023
@github-actions github-actions bot added services/cert-manager services/external-dns size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented May 11, 2023

Pull Request Test Coverage Report for Build 5017385546

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 4945944319: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

Co-authored-by: Grace Do <xgrace@gmail.com>
@sonofgibs sonofgibs requested review from gracedo and a team May 18, 2023 19:10
@sonofgibs sonofgibs added ready-for-review and removed do-not-merge/testing Do not merge because there is still on-going testing labels May 18, 2023
@sonofgibs sonofgibs merged commit 9539a21 into main May 18, 2023
18 checks passed
@sonofgibs sonofgibs deleted the zgibson/D2IQ-96663Tools branch May 18, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/cert-manager services/external-dns size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants