feat: dynamic containerd install per OS #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiq
force-pushed
the
faiq/containerd-tar
branch
4 times, most recently
from
64d3e2b
to
bd763e2
Compare
dlipovetsky
reviewed
May 23, 2022
dlipovetsky
reviewed
May 23, 2022
faiq
force-pushed
the
faiq/containerd-tar
branch
3 times, most recently
from
a08d833
to
fa21d2d
Compare
|
|
faiq
commented
May 24, 2022
dlipovetsky
added a commit
that referenced
this pull request
May 24, 2022
* WIP d2iq containerd centos 7.9 tarball * feat: dynamic containerd base url * chore: try checking for fips another way * chore: adds comment explaining containerd tar and installs ansible utils in prod container * chore: move centos7 -> centos7.9 * fix: adds more context to os_distribution_major_minor_version * fix: change where we set our containerd facts from * fix: add different suffix for fips and containerd * chore: move centos7 to centos7.9 * fix: remove containerd bundle suffix and add arch to containerd build * Update ansible/roles/containerd/tasks/install.yaml Co-authored-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Pulls down the appropriate containerd binary for OS + fips combination.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: