-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parse command output without using shell pipelines #369
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against d7467a1 |
daffba7
to
010dc61
Compare
After #367 merged, I rebased on main and force-pushed. The e2e tests should now pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing all tasks
Ubuntu 18.04 and 20.04 tests are failing apparently because |
010dc61
to
7f6a328
Compare
I tried to fix this by relying on |
d538a8f
to
cbdbd59
Compare
cbdbd59
to
330a4c7
Compare
Sadly and unexpectedly, the cli_parse module didn't work for my needs, and its errors were inscrutable. So I went with regex parsing. |
b11c409
to
32c9952
Compare
32c9952
to
0d23c47
Compare
0d23c47
to
d7467a1
Compare
What problem does this PR solve?:
Errors are not being caught when the shell module executes a pipeline. For example, see #367 (comment)
It's possible to catch errors by using the
pipefail
shell option, but only if the shell supports it. In every case where we use a pipeline, we use it to parse command output. Instead of catching errors, we can just stop using pipelines.Which issue(s) does this PR fix?:
Special notes for your reviewer:
The e2e tests fail, as expected. They will pass once #367 is merged.Merged.Does this PR introduce a user-facing change?: