Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authenticate to vsphere base template using ssh private key and ssh auth agent. #498

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

supershal
Copy link
Collaborator

What problem does this PR solve?:

  • Reverts disabling ssh password authentication for all the users and adds deprecation warning
  • Enables ssh private key and ssh auth agent based authentication for base templates

Which issue(s) does this PR fix?:

Special notes for your reviewer:

The warning will be ansible debug statement

 vsphere-clone: TASK [sysprep : Deprecation warning for disabling password authentication] *****
      sphere-clone: ok: [default] => {
vsphere-clone:     "msg": "WARN: SSH password based authentication will be disabled in future releases"
      vsphere-clone: }

Does this PR introduce a user-facing change?:

enable ssh private key and ssh agent based authentication for vsphere image builder 

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022

File Coverage
All files 15%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 0%
pkg/app/build_azure.go 2%
pkg/app/build_gcp.go 0%
pkg/app/config.go 48%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/utils.go 7%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 93b60ae

@supershal supershal self-assigned this Sep 13, 2022
@supershal supershal changed the title feat: authenticate to vsphere base template using ssh private key and ssh auth agent feat: authenticate to vsphere base template using ssh private key and ssh auth agent. Sep 13, 2022
@github-actions github-actions bot added feature and removed feature labels Sep 13, 2022
@supershal
Copy link
Collaborator Author

Since we built the new base 7.9 template from scratch again the intermittent shutdown problem is back :(
centos 7.9 build failed because of shutdown:
https://teamcity.mesosphere.io/buildConfiguration/ClosedSource_KonvoyImageBuilder_E2eRhel79ovaOfflineFips/3606599?
centos 7.9 FIPS build passed: https://teamcity.mesosphere.io/buildConfiguration/ClosedSource_KonvoyImageBuilder_Bui/3606612?buildTab=log&focusLine=3377&linesState=430

All RHEL 8.4 OVA build passed.
We will have to replace base template for RHEL 7.9 manually in vsphere.

@supershal supershal merged commit aa4b7a5 into main Sep 13, 2022
@supershal supershal deleted the shalin/deprecate-ssh-password-auth branch September 13, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants