Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload nvidia runfile for offline preprovisioned #511

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

faiq
Copy link
Collaborator

@faiq faiq commented Sep 27, 2022

What problem does this PR solve?:
gpu won't be defined when we run upload artifacts. we should remove this.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added the fix label Sep 27, 2022
@github-actions
Copy link
Contributor

File Coverage
All files 14%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 0%
pkg/app/build_azure.go 2%
pkg/app/build_gcp.go 0%
pkg/app/config.go 48%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/utils.go 7%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against e6905ae

@faiq faiq changed the title fix: upload nvidia runfile fix: upload nvidia runfile for offline preprovisioned Sep 27, 2022
@github-actions github-actions bot added fix and removed fix labels Sep 27, 2022
@faiq faiq merged commit 2bc6762 into main Sep 27, 2022
@faiq faiq deleted the faiq/fix-nvidia-upload branch September 27, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant