Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: epel repos not working with some RHEL images #676

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

dkoshkin
Copy link
Contributor

What problem does this PR solve?:
Seen in Azure where $releasever is not being correctly replaced, but can happen in other images

I was able to repro this issue in Azure and test this fix, see:

TASK [repo : add alma linux extra repository] **********************************
changed: [20.228.111.34]

TASK [repo : install epel-release for RHEL 8.x] ********************************
changed: [20.228.111.34]

TASK [repo : find epel-release repo files] *************************************
ok: [20.228.111.34]

TASK [repo : set $releasever variables in epel-release repo files] *************
changed: [20.228.111.34] => (item={'path': '/etc/yum.repos.d/epel-modular.repo', 'mode': '0644', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 0, 'gid': 0, 'size': 1177, 'inode': 2118938, 'dev': 64772, 'nlink': 1, 'atime': 1607202791.0, 'mtime': 1607202791.0, 'ctime': 1676064021.6165278, 'gr_name': 'root', 'pw_name': 'root', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': True, 'xoth': False, 'isuid': False, 'isgid': False})
changed: [20.228.111.34] => (item={'path': '/etc/yum.repos.d/epel-playground.repo', 'mode': '0644', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 0, 'gid': 0, 'size': 1259, 'inode': 2118939, 'dev': 64772, 'nlink': 1, 'atime': 1607202791.0, 'mtime': 1607202791.0, 'ctime': 1676064021.6165278, 'gr_name': 'root', 'pw_name': 'root', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': True, 'xoth': False, 'isuid': False, 'isgid': False})
changed: [20.228.111.34] => (item={'path': '/etc/yum.repos.d/epel-testing-modular.repo', 'mode': '0644', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 0, 'gid': 0, 'size': 1276, 'inode': 2118940, 'dev': 64772, 'nlink': 1, 'atime': 1607202791.0, 'mtime': 1607202791.0, 'ctime': 1676064021.6175277, 'gr_name': 'root', 'pw_name': 'root', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': True, 'xoth': False, 'isuid': False, 'isgid': False})
changed: [20.228.111.34] => (item={'path': '/etc/yum.repos.d/epel-testing.repo', 'mode': '0644', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 0, 'gid': 0, 'size': 1213, 'inode': 2118941, 'dev': 64772, 'nlink': 1, 'atime': 1607202791.0, 'mtime': 1607202791.0, 'ctime': 1676064021.6175277, 'gr_name': 'root', 'pw_name': 'root', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': True, 'xoth': False, 'isuid': False, 'isgid': False})
changed: [20.228.111.34] => (item={'path': '/etc/yum.repos.d/epel.repo', 'mode': '0644', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 0, 'gid': 0, 'size': 1114, 'inode': 2118942, 'dev': 64772, 'nlink': 1, 'atime': 1607202791.0, 'mtime': 1607202791.0, 'ctime': 1676064021.6175277, 'gr_name': 'root', 'pw_name': 'root', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': True, 'xoth': False, 'isuid': False, 'isgid': False})
...
TASK [setup_versionlock : install yum utilities] *******************************
changed: [20.228.111.34]

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Seen in Azure where $releasever is not being correctly replaced, but can happen in other images
@dkoshkin dkoshkin self-assigned this Feb 10, 2023
@github-actions github-actions bot added the fix label Feb 10, 2023
@github-actions
Copy link
Contributor

File Coverage
All files 14%
cmd/konvoy-image-wrapper/cmd/wrapper.go 8%
cmd/konvoy-image-wrapper/image/common.go 0%
cmd/konvoy-image-wrapper/image/image_not_embedded.go 0%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 0%
pkg/app/build_azure.go 2%
pkg/app/build_gcp.go 0%
pkg/app/config.go 50%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/utils.go 7%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 802174e

@dkoshkin dkoshkin added the runs-e2e-tests runs e2e tests for GHA label Feb 10, 2023
Copy link
Collaborator

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for gating these changes on the RHEL version, and for the helpful comment.

@dlipovetsky dlipovetsky merged commit aae136a into main Feb 14, 2023
@dlipovetsky dlipovetsky deleted the dkoshkin/fix-epel-repo-files-rhel8 branch February 14, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix runs-e2e-tests runs e2e tests for GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants