fix: run flatcar update scripts only in ansible playbook #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supershal
changed the title
supershal
force-pushed
the
shalin/simplify_flatcar
branch
from
ab6e9fc
to
0faa262
Compare
supershal
changed the title
faiq
approved these changes
Apr 19, 2023
dkoshkin
approved these changes
Apr 26, 2023
faiq
pushed a commit
that referenced
this pull request
Aug 20, 2023
* chore: run flatcar update scripts only in ansible playbook * chore: set path for ansible playbooks * chore: remove deprecated packer folder from Dockerfile
faiq
pushed a commit
that referenced
this pull request
Aug 20, 2023
* chore: run flatcar update scripts only in ansible playbook * chore: set path for ansible playbooks * chore: remove deprecated packer folder from Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Move flatcar update and bootstrap scripts to ansible playbooks.
Currently it is executed twice in packer
shellprovisioner andansible playbooks.use
path.cwdinbuilt variable to fix the path of the ansible playbooks.Special notes for your reviewer:
I was not aware of original intent of keeping it in two places. I am not sure if it was intentional.
Please let me know if flatcar scripts was executed in
packerintentionally.