Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force update the offline repo metadata cache #829

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Jun 8, 2023

What problem does this PR solve?:
This an issue thats wasn't caught in KIB tests because there are no upgrade tests here (as there shouldn't be).

This did not fail in Konvoy's e2e air-gapped preprovisioned upgrad tests because the package there was rebuilt more recently, but the FIPS packages were not.

I'm going to add a Konvoy FIPS preprovisioned upgrade test that would have caught this kind of issue in future. I ran the test with a customer KIB image built with this fix and it got updated:

  STEP: Upgrading the control-plane nodes @ 06/08/23 11:19:21.748
  /home/rocky/konvoy [update controlplane preprovisioned -c e2e-preprov-fips-upgrade-16862466 --kubeconfig /home/rocky/e2e-preprov-fips-upgrade-16862466.conf --kubernetes-version 1.26.3+fips.0]
  2023-06-08 18:19:21 INF  • Updating the control plane...
  2023-06-08 18:19:21 INF Updating control plane resource controlplane.cluster.x-k8s.io/v1beta1, Kind=KubeadmControlPlane default/e2e-preprov-fips-upgrade-16862466-control-plane
  2023-06-08 18:19:21 INF Waiting for control plane update to finish.
  2023-06-08 18:47:31 INF  ✓ Updating the control plane
  STEP: Upgrading the nodepool nodes @ 06/08/23 11:47:31.833
  /home/rocky/konvoy [update nodepool preprovisioned -c e2e-preprov-fips-upgrade-16862466 --kubeconfig /home/rocky/e2e-preprov-fips-upgrade-16862466.conf --kubernetes-version 1.26.3+fips.0 e2e-preprov-fips-upgrade-16862466-md-0]
  2023-06-08 18:47:32 INF  • Updating the e2e-preprov-fips-upgrade-16862466-md-0 node pool...
  2023-06-08 18:47:32 INF Updating node pool resource cluster.x-k8s.io/v1beta1, Kind=MachineDeployment default/e2e-preprov-fips-upgrade-16862466-md-0
  2023-06-08 18:47:32 INF Waiting for node pool update to finish.
  2023-06-08 18:59:22 INF  ✓ Updating the e2e-preprov-fips-upgrade-16862466-md-0 node pool

New tasks in KIB job:

TASK [repo : clean metadata for offline repository] ****************************
changed: [10.0.132.5]

TASK [repo : update the cache for offline repository] **************************
changed: [10.0.132.5]

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@dkoshkin dkoshkin requested a review from a team June 8, 2023 20:12
@dkoshkin dkoshkin self-assigned this Jun 8, 2023
@github-actions github-actions bot added the fix label Jun 8, 2023
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Jun 8, 2023

@github-actions github-actions bot added fix and removed fix labels Jun 9, 2023
Copy link
Collaborator

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug! Thanks for fixing, and the comment.

@dlipovetsky dlipovetsky merged commit 944d313 into main Jun 9, 2023
@dlipovetsky dlipovetsky deleted the dkoshkin/fix-update-metadata branch June 9, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants