Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update k8s debian package repositories to pkgs.k8s.io, bumps critools to 1.28 #996

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

kaiwalyajoshi
Copy link
Contributor

@kaiwalyajoshi kaiwalyajoshi commented Feb 14, 2024

What problem does this PR solve?:

  • Update debian package repositories to use pkgs.k8s.io
  • Bump critools to v1.28

Which issue(s) does this PR fix?:

Special notes for your reviewer:

  • There was an attempt to template kubernetes_version via
    {{ kubernetes_major }}.{{ kubernetes_minor }}.{{ kubernetes_patch}} but this fails many tests as the templated version is referenced by the Magefile here.

Does this PR introduce a user-facing change?:


@kaiwalyajoshi kaiwalyajoshi added runs-e2e-tests runs e2e tests for GHA and removed runs-azure-tests labels Feb 14, 2024
@kaiwalyajoshi kaiwalyajoshi changed the title chore: Update k8s debian package repositories to pkgs.k8s.io chore: Update k8s debian package repositories to pkgs.k8s.io, bump critools to 1.28 Feb 14, 2024
@cwyl02
Copy link
Contributor

cwyl02 commented Feb 14, 2024

added a commit to use 1.28.6 so its consistent with #988

@cwyl02 cwyl02 force-pushed the kjoshi/update-k8s-package-repos branch from f8454c5 to 269c974 Compare February 14, 2024 10:56
ansible/group_vars/all/defaults.yaml Outdated Show resolved Hide resolved
ansible/group_vars/all/defaults.yaml Outdated Show resolved Hide resolved
@supershal supershal changed the title chore: Update k8s debian package repositories to pkgs.k8s.io, bump critools to 1.28 chore: Update k8s debian package repositories to pkgs.k8s.io, bump critools to 1.28 Feb 14, 2024
@dlipovetsky
Copy link
Collaborator

Thanks for this. I fixed the deb revision in the dkp-release repo, but not here. I'll want to backport this to release-2.5

cwyl02 and others added 2 commits February 14, 2024 23:16
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com>
@cwyl02 cwyl02 force-pushed the kjoshi/update-k8s-package-repos branch from 2f6415e to ca519c9 Compare February 15, 2024 08:31
@dlipovetsky
Copy link
Collaborator

Thanks for the fixes @cwyl02!

@dlipovetsky dlipovetsky dismissed supershal’s stale review February 15, 2024 17:57

Requested changes made

Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its safe to ignore the nvidia kernel mismatch since the Ubuntu e2e passed

@faiq faiq changed the title chore: Update k8s debian package repositories to pkgs.k8s.io, bump critools to 1.28 chore: Update k8s debian package repositories to pkgs.k8s.io, bumps critools to 1.28 Feb 15, 2024
@faiq faiq changed the title chore: Update k8s debian package repositories to pkgs.k8s.io, bumps critools to 1.28 fix: Update k8s debian package repositories to pkgs.k8s.io, bumps critools to 1.28 Feb 15, 2024
@faiq faiq merged commit d9bbc94 into main Feb 15, 2024
61 of 66 checks passed
@faiq faiq deleted the kjoshi/update-k8s-package-repos branch February 15, 2024 18:19
dlipovetsky pushed a commit that referenced this pull request Feb 20, 2024
…tools to 1.28 (#996)

* chore: Update k8s debian package repositories to pkgs.k8s.io
---------
Co-authored-by: York Chen <york.chen@nutanix.com>
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com

Signed-off-by: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
dlipovetsky pushed a commit that referenced this pull request Feb 20, 2024
---------
Co-authored-by: York Chen <york.chen@nutanix.com>
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com

Signed-off-by: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
dlipovetsky pushed a commit that referenced this pull request Feb 20, 2024
---------
Co-authored-by: York Chen <york.chen@nutanix.com>
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com

Signed-off-by: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
dlipovetsky pushed a commit that referenced this pull request Feb 22, 2024
---------
Co-authored-by: York Chen <york.chen@nutanix.com>
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com

Signed-off-by: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
dlipovetsky added a commit that referenced this pull request Feb 22, 2024
)

---------

Co-authored-by: Shalin Patel <shalin.patel@nutanix.com

Signed-off-by: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
Co-authored-by: Kaiwalya R Joshi <kaiwalya.joshi@nutanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix runs-e2e-tests runs e2e tests for GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants