fix: set limitnofile #713
Merged
fix: set limitnofile #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
approved these changes
Mar 2, 2023
mkarroqe
approved these changes
Mar 2, 2023
supershal
approved these changes
Mar 2, 2023
|
When we upgraded containerd 1.4 to 1.6, the systemd unit changed the file descriptor limit from |
dlipovetsky
approved these changes
Mar 2, 2023
|
Looking upstream this seems to be caused by this PR which sets the containerd limits to unlimited, users who were previously on 1.4.13 version of containerd provided by dkp 2.4 and previous had this limit set. Removing this limit caused our rook deployment to break and we also saw problem with HA proxy as well which had this limit as the root cause. We decided to bring this limit back for a couple of reasons
|
faiq
force-pushed
the
faiq/containerd-filelimit
branch
from
bdc833d
to
d5b0c02
Compare
faiq
force-pushed
the
faiq/containerd-filelimit
branch
from
7a75cf5
to
c2559a9
Compare
|
@faiq I think we are good to merge this, the 2 other fixes look good: |
fatz
reviewed
Mar 8, 2023
| template: | ||
| dest: /etc/systemd/system/containerd.service.d/max-files.conf | ||
| src: etc/systemd/system/containerd.service.d/max-files.conf | ||
| mode: 0644 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
https://d2iq.atlassian.net/browse/D2IQ-96107
This change in contained seems to cause problems for workloads that use disk containerd/containerd#4475
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: