Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.x] Kommander 1.0.1 bits n pieces #62

Merged
merged 3 commits into from May 5, 2020
Merged

[1.0.x] Kommander 1.0.1 bits n pieces #62

merged 3 commits into from May 5, 2020

Conversation

juliangieseke
Copy link
Contributor

@juliangieseke juliangieseke commented Apr 28, 2020 •
edited

@juliangieseke juliangieseke requested a review from a team as a code owner April 28, 2020 14:48
@hectorj2f
Copy link

can we get the KCL version bump as part of this PR ? or do we prefer to do it as part of a different PR ?

@juliangieseke
Copy link
Contributor Author

this PR is fine 👍

@juliangieseke
Copy link
Contributor Author

linking KCL PR for easier monitoring: https://github.com/mesosphere/kommander-cluster-lifecycle/pull/518

@msdolbey msdolbey changed the title [1.0.x] add 1.16.8 [1.0.x] add 1.16.8 D2IQ-67475 Apr 28, 2020
@msdolbey
Copy link

Related to this JIRA:
D2IQ-67475

msdolbey
msdolbey previously approved these changes Apr 28, 2020
View reviewed changes
Copy link

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Now I get it

@juliangieseke juliangieseke changed the title [1.0.x] add 1.16.8 D2IQ-67475 [1.0.x] Kommander 1.0.1 bits n pieces Apr 28, 2020
@juliangieseke
Copy link
Contributor Author

also related to https://jira.d2iq.com/browse/D2IQ-67811

@shaneutt shaneutt requested a review from hectorj2f April 28, 2020 19:23
@jimmidyson jimmidyson mentioned this pull request Apr 30, 2020
Closed
@juliangieseke juliangieseke dismissed msdolbey’s stale review April 30, 2020 15:46

dismissing after kcl update

@shaneutt
Copy link
Contributor

shaneutt commented May 5, 2020

@juliangieseke this is marked as wip but it looks ready is it ready?

@juliangieseke juliangieseke merged commit 6bb0163 into stable-1.0.x May 5, 2020
@juliangieseke juliangieseke deleted the jg/kommander-1.0.1-touchups branch May 5, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorj2f hectorj2f hectorj2f approved these changes

@GeorgiSTodorov GeorgiSTodorov GeorgiSTodorov approved these changes

@msdolbey msdolbey msdolbey left review comments

Assignees

@juliangieseke juliangieseke

Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juliangieseke @hectorj2f @msdolbey @shaneutt @GeorgiSTodorov @jimmidyson