Fix logout button #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alembiewski
requested review from
timcharper,
juliangieseke,
alexeygorobets,
MessKon and
lukeogg
MessKon
reviewed
May 31, 2022
| } | ||
|
|
||
| /** | ||
| * Set 'Authorization' header based on the existing cookie. |
There was a problem hiding this comment.
looking at this page the authservice creates a session cookie.
does the logout button with the suggested change delete this cookie?
meaning... once logged out from one user, can we immediately log in with a new user with no issues?
There was a problem hiding this comment.
yes, a session cookie is removed after the user logs out, it is done via Set-Cookie header: https://github.com/arrikto/oidc-authservice/blob/ae92e8656c5252eddb305f6b9bb72ae1e1e61f6c/session.go#L75
alembiewski
added a commit
that referenced
this pull request
Aug 8, 2022
* Pin alpine repository version * Introduce a new LogoutButton component
MessKon
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Pin alpine repository version * Introduce a new LogoutButton component
MessKon
pushed a commit
that referenced
this pull request
Oct 20, 2022
* Pin alpine repository version * Introduce a new LogoutButton component
alembiewski
added a commit
that referenced
this pull request
Feb 6, 2023
* Pin alpine repository version * Introduce a new LogoutButton component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes logout functionality by introducing a new
LogoutButtoncomponent, responsible for sending logout requests to the backend auth service. A few important points: