Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-bump][chart] traefik-forward-auth-0.3.3 #1314

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

d2iq-dispatch
Copy link
Contributor

@d2iq-dispatch d2iq-dispatch commented Sep 14, 2021

What type of PR is this?

Bug

What this PR does/ why we need it:

Bumping to TFA >3.0.0 caused below error in YAKCL https://github.com/mesosphere/yakcl/pull/438

auth/templates/hooks.yaml failed: Job.batch \"traefik-forward-auth-kommander-kubeaddons-session-key-pre-install\" is invalid: spec.template.labels: Invalid value: \"traefik-forward-auth-kommander-kubeaddons-session-key-pre-install\": must be no more than 63 characters"}

I did not find any examples of using generateName in our charts and an upstream issue helm/helm#3348 so decided to go with the safer route and just shorten the name to something that will be <=63 characters

traefik-forward-auth-kommander-kubeaddons-sess-key-pre-install
traefik-forward-auth-kommander-kubeaddons-sess-key-post-delete

Which issue(s) this PR fixes:

Special notes for your reviewer:
Testing this fix in https://github.com/mesosphere/yakcl/pull/438

Does this PR introduce a user-facing change?:

traefik-forward-auth: shorten hook names to be within 63 character length.

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@d2iq-dispatch d2iq-dispatch requested a review from a team as a code owner September 14, 2021 21:28
@d2iq-dispatch d2iq-dispatch added the help wanted Extra attention is needed label Sep 14, 2021
@d2iq-mergebot
Copy link
Contributor

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

@gracedo gracedo added needs backport and removed help wanted Extra attention is needed labels Sep 15, 2021
@dkoshkin
Copy link
Contributor

@mesosphere-mergebot backport release/4

@dkoshkin
Copy link
Contributor

@mesosphere-mergebot backport release/3

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/4: #1316

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/3: #1317
Conflicts present in files:

addons/traefik-forward-auth/traefik-forward-auth.yaml

@gracedo gracedo merged commit c9af55d into master Sep 15, 2021
@gracedo gracedo deleted the bump-traefik-forward-auth-b29bfb6c branch September 15, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants