Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] use master branches in e2e tests #579

Closed
wants to merge 2 commits into from
Closed

[Test] use master branches in e2e tests #579

wants to merge 2 commits into from

Conversation

juliangieseke
Copy link
Contributor

What type of PR is this?

What this PR does/ why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@juliangieseke juliangieseke requested a review from a team as a code owner October 7, 2020 15:43
joejulian
joejulian suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in kba should be testing the addons in kba, not downstream or adjacent projects. I'd prefer we don't merge this.

@joejulian joejulian added this to the release/3.0 milestone Oct 7, 2020
@juliangieseke
Copy link
Contributor Author

not sure I agree :) but this PR wasnt meant to be merged anyway (at least not yet).

@joejulian joejulian deleted the jg/ui-e2e-master-branches branch February 2, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejulian joejulian joejulian requested changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
release/3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliangieseke @joejulian