Add a plugin loading is finished getter

mesosphere · Feb 10, 2016 · 06d6534 · aldipower · Feb 10, 2016 · 06d6534
1 parent f58d841
commit 06d6534
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/js/components/Marathon.jsx b/src/js/components/Marathon.jsx
@@ -58,14 +58,8 @@ var Marathon = React.createClass({
     this.onRouteChange();
   },
 
-  isPluginLoadingComplete: function () {
-    var pluginLoadingState = PluginStore.pluginsLoadingState;
-    return pluginLoadingState !== States.STATE_INITIAL &&
-      pluginLoadingState !== States.STATE_LOADING;
-  },
-
   onPluginStoreChange: function () {
-    if (this.isPluginLoadingComplete()) {
+    if (PluginStore.isPluginsLoadingFinished) {
       this.startPolling();
     }
   },
@@ -122,7 +116,7 @@ var Marathon = React.createClass({
     /* eslint-disable eqeqeq */
     if ((prevState.activeAppId != this.state.activeAppId ||
         prevState.activeTabId != this.state.activeTabId) &&
-        this.isPluginLoadingComplete()) {
+      PluginStore.isPluginsLoadingFinished) {
       this.resetPolling();
     }
     /* eslint-enable eqeqeq */

diff --git a/src/js/stores/PluginStore.js b/src/js/stores/PluginStore.js
@@ -87,6 +87,13 @@ var PluginStore = Util.extendObject({
 
       });
   },
+
+  get isPluginsLoadingFinished() {
+    var pluginLoadingState = this.pluginsLoadingState;
+    return pluginLoadingState !== States.STATE_INITIAL &&
+      pluginLoadingState !== States.STATE_LOADING;
+  },
+
   resetStore: function () {
     plugins = [];
   }