Fix application error invalidation

Assume that the supplied filed values as well as the whole config is valid on app form change. Closes mesosphere/marathon#3494
mesosphere · Mar 21, 2016 · 1268fe9 · 1268fe9
1 parent 1d82083
commit 1268fe9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/js/components/AppConfigEditFormComponent.jsx b/src/js/components/AppConfigEditFormComponent.jsx
@@ -114,8 +114,10 @@ var AppConfigEditFormComponent = React.createClass({
   onFormChange: function (fieldId) {
     var responseErrorMessages = this.state.responseErrorMessages;
 
-    if (responseErrorMessages != null &&
-        responseErrorMessages[fieldId] != null) {
+    // At present we assume that the supplied filed value as well as the general
+    // config is valid.
+    if (responseErrorMessages != null ) {
+      delete responseErrorMessages["general"];
       delete responseErrorMessages[fieldId];
     }
 

diff --git a/src/js/components/modals/AppModalComponent.jsx b/src/js/components/modals/AppModalComponent.jsx
@@ -92,6 +92,7 @@ var AppModalComponent = React.createClass({
       });
     } else {
       this.setState({
+        appIsValid: false,
         error: AppFormStore.responseErrors
       });
     }