Use plugin events instead of simple strings

mesosphere · Feb 9, 2016 · 37ee8ba · 37ee8ba
1 parent 3b110b4
commit 37ee8ba
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/js/plugin/PluginLoader.js b/src/js/plugin/PluginLoader.js
@@ -45,7 +45,7 @@ const PluginLoader = {
         });
 
         let dispatchToken = PluginDispatcher.register(function (event) {
-          if (event.eventType === "STARTUP_COMPLETE"
+          if (event.eventType === PluginEvents.STARTUP_COMPLETE
               && event.pluginId === pluginId) {
             PluginDispatcher.unregister(dispatchToken);
 

diff --git a/src/js/plugin/external/PluginEvents.js b/src/js/plugin/external/PluginEvents.js
@@ -2,6 +2,7 @@ import Util from "../../helpers/Util";
 
 const PluginEvents = Util.objectCreateWithAdder("PLUGIN_EVENTS_");
 
-["APPS_STORE_CHANGE"].forEach(PluginEvents.add);
+["STARTUP_COMPLETE", "INJECT_COMPONENT","APPS_STORE_CHANGE"]
+  .forEach(PluginEvents.add);
 
 export default PluginEvents;
diff --git a/src/js/stores/PluginComponentStore.js b/src/js/stores/PluginComponentStore.js
@@ -2,6 +2,7 @@ import {EventEmitter} from "events";
 import React from "react/addons";
 
 import PluginDispatcher from "../plugin/external/PluginDispatcher";
+import PluginEvents from "../plugin/external/PluginEvents";
 import PluginComponentEvents from "../events/PluginComponentEvents";
 
 import Util from "../helpers/Util";
@@ -15,7 +16,7 @@ var PluginComponentStore = Util.extendObject(EventEmitter.prototype, {
 });
 
 PluginDispatcher.register(event => {
-  if (event.eventType === "INJECT_COMPONENT") {
+  if (event.eventType === PluginEvents.INJECT_COMPONENT) {
     let componentObj = {
       placeId: event.placeId,
       component: event.component