Remove some duplicated code

mesosphere · Mar 2, 2016 · 914d069 · 914d069
1 parent 8d7d285
commit 914d069
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/js/components/AppConfigEditFormComponent.jsx b/src/js/components/AppConfigEditFormComponent.jsx
@@ -156,7 +156,7 @@ var AppConfigEditFormComponent = React.createClass({
 
     var volumesIsOpen = this.fieldsHaveError({volumes: "volumes"});
 
-    if (state.isVolumesOpen === true) {
+    if (state.isVolumesOpen) {
       volumesIsOpen = state.isVolumesOpen;
     }
 

diff --git a/src/js/components/CollapsiblePanelComponent.jsx b/src/js/components/CollapsiblePanelComponent.jsx
@@ -1,5 +1,6 @@
 import classNames from "classnames";
 import React from "react";
+import Util from "../helpers/Util";
 
 var CollapsiblePanelComponent = React.createClass({
   displayName: "CollapsiblePanelComponent",
@@ -14,7 +15,7 @@ var CollapsiblePanelComponent = React.createClass({
   getDefaultProps: function () {
     return {
       isOpen: false,
-      togglePanel: function () {}
+      togglePanel: Util.noop
     };
   },
 

diff --git a/src/js/components/ContainerSettingsComponent.jsx b/src/js/components/ContainerSettingsComponent.jsx
@@ -275,8 +275,7 @@ var ContainerSettingsComponent = React.createClass({
         <h4>Parameters</h4>
         <div className="duplicable-list">{this.getParametersRows()}</div>
         <div>
-          You can set your Docker volume
-          settings <a onClick={this.props.openVolumes}>
+          You can set your Docker volume <a onClick={this.props.openVolumes}>
             below
           </a>.
         </div>