Switch to object to boost performance

Using a sparse array to keep track of consecutive row keys has some major performance hits on certain browsers (i.e. Safari OSX) when using .slice() (as done by Util.deepCopy).
mesosphere · Mar 30, 2016 · dfe8c71 · dfe8c71
1 parent 641ab0b
commit dfe8c71
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/js/components/AppConfigEditFormComponent.jsx b/src/js/components/AppConfigEditFormComponent.jsx
@@ -141,7 +141,7 @@ var AppConfigEditFormComponent = React.createClass({
   getErrorMessage: function (fieldId) {
     var state = this.state;
     var errorIndex = state.errorIndices[fieldId];
-    if (errorIndex != null && !Util.isArray(errorIndex)) {
+    if (errorIndex != null && !Util.isObject(errorIndex)) {
       return AppFormErrorMessages.getFieldMessage(fieldId, errorIndex);
     }
     if (state.responseErrorMessages[fieldId] != null) {

diff --git a/src/js/stores/AppFormStore.js b/src/js/stores/AppFormStore.js
@@ -252,7 +252,7 @@ function updateErrorIndices(fieldId, value, errorIndices) {
   var errorIndex = getValidationErrorIndex(fieldId, value);
   if (errorIndex > -1) {
     if (value.consecutiveKey != null) {
-      Util.initKeyValue(errorIndices, fieldId, []);
+      Util.initKeyValue(errorIndices, fieldId, {});
       errorIndices[fieldId][value.consecutiveKey] = errorIndex;
     } else {
       errorIndices[fieldId] = errorIndex;