Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ViewHelper to Path #315

Merged
merged 1 commit into from Oct 16, 2015

Conversation

aldipower
Copy link
Contributor

As discussed, I'll do this in a seperate PR here now.

@orlandohohmeier
Copy link
Contributor

Yeah, great! 😃 But why did you remove the "Helper" suffix? We have the "Component" suffix for components and "Event" for all events...

@aldipower
Copy link
Contributor Author

The Path-object is generic usable collection of functions. The Helper suffix is meaningless here imho.
Also I don't think the word 'Helper' fits the meaning of processing functions.

The other suffixes you've mentioned are meant to express the architectural flow and also by convention from React/Flux.
Consider:

AppListComponent
AppListActions
AppListStore
AppListEvents

This fits in the application architecture and has unique meanings. They depend on each other.

@orlandohohmeier
Copy link
Contributor

You're right, the suffix is not needed. But I would add the suffix anyway, just to have fewer conventions/rules without any exceptions.

@aldipower
Copy link
Contributor Author

I could live with PathUtil. But derive the suffix from the pathname the file lives in, isn't a convention to me.

@orlandohohmeier
Copy link
Contributor

Don't you move specific files to specific dirs, because of their type? Thus the convention is to suffix files with their type and move them to the respective dir...

PathUtil sounds good to me. What about also renaming the dir (helpers->utils)?

@aldipower
Copy link
Contributor Author

Every rule has exceptions. :)
And I would say the rule here is more the other way around.
I'll name the directory derived from the files, because I gathered a bunch of files of the same type.
Files first.
I don't name the files, derived from the directory name, that doesn't makes sense to me.
Sounds maybe nitpicking.
Will rename the file to PathUtil.

@orlandohohmeier
Copy link
Contributor

That's exactly what I meant. Any how, LGTM! 😄

orlandohohmeier pushed a commit that referenced this pull request Oct 16, 2015
@orlandohohmeier orlandohohmeier merged commit 8846f4a into project-rhabarber Oct 16, 2015
@orlandohohmeier orlandohohmeier deleted the refactor/rename-viewhelp branch October 16, 2015 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants