New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ViewHelper to Path #315
Conversation
Yeah, great! 😃 But why did you remove the "Helper" suffix? We have the "Component" suffix for components and "Event" for all events... |
The Path-object is generic usable collection of functions. The Helper suffix is meaningless here imho. The other suffixes you've mentioned are meant to express the architectural flow and also by convention from React/Flux.
This fits in the application architecture and has unique meanings. They depend on each other. |
You're right, the suffix is not needed. But I would add the suffix anyway, just to have fewer conventions/rules without any exceptions. |
I could live with |
Don't you move specific files to specific dirs, because of their type? Thus the convention is to suffix files with their type and move them to the respective dir...
|
Every rule has exceptions. :) |
32dee59
to
b9c5863
Compare
That's exactly what I meant. Any how, LGTM! 😄 |
Rename ViewHelper to Path
As discussed, I'll do this in a seperate PR here now.