Docker volumes should not trigger warning #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (model.container != null && model.container.volumes != null && | ||
| model.instances > instances | ||
| ) { | ||
| if (model.container != null && |
There was a problem hiding this comment.
Please also fix the handleSuspendApp condition, and maybe move the persistent volume app condition into a util.
There was a problem hiding this comment.
Thanks for noticing. I also realised we should still show the warning if the volume has .external defined. Force-pushed some changes.
pierluigi
force-pushed
the
fix/stateful-warning
branch
from
8a4a3fc
to
c804e4a
Compare
| return app.container != null && | ||
| app.container.volumes != null && | ||
| app.container.volumes | ||
| .filter(volume => volume.persistent != null || volume.external != null) |
There was a problem hiding this comment.
You could use volumes.some(volume => volume.persistent != null || volume.external != null) to check if there is at least one persistent volume.
There was a problem hiding this comment.
Good idea. I'll do it.
pierluigi
force-pushed
the
fix/stateful-warning
branch
from
c804e4a
to
0aa186f
Compare
added 2 commits
April 19, 2016 11:02
pierluigi
force-pushed
the
fix/stateful-warning
branch
from
f368849
to
983a01b
Compare
|
gerebased |
|
Looks good to me! Let's 🚢 🇮🇹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes mesosphere/marathon#3794