Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3447 fix link #765

Merged

Conversation

tmmi
Copy link
Contributor

@tmmi tmmi commented May 10, 2016

@@ -62,6 +62,8 @@ var AppDebugInfoComponent = React.createClass({
);
}

lastTaskFailure.id = lastTaskFailure.id || lastTaskFailure.taskId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add test case for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, test added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you for this!

@tmmi tmmi force-pushed the bugfix/link_to_mesos_details_in_debug branch 3 times, most recently from 0a0d76b to 36272ac Compare May 18, 2016 12:29
@tmmi tmmi force-pushed the bugfix/link_to_mesos_details_in_debug branch from 36272ac to cf1cdbc Compare May 18, 2016 15:46
@kamilchm
Copy link

@philipnrmn ?

@kamilchm
Copy link

@jasongilanfarr @gkleiman ? anyone at @mesosphere-ci ;)

@aldipower
Copy link
Contributor

Thank you for taking care of this!

@aldipower aldipower merged commit aebf590 into mesosphere:master Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants