Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that the 'apply' button is broken #766

Merged
merged 2 commits into from
Jul 25, 2016

Conversation

dave-re
Copy link
Contributor

@dave-re dave-re commented May 17, 2016

I found that 'apply' button is broken on the marathon v1.1.1.
It's because 'appVersions' property of 'AppVersionsStore' object hasn't the latest version app.

// Diff the new configuration against the current app settings
  getAppConfigDiff: function (appId, newConfig) {
    var allVersions = this.getAppVersions(appId);
    if (allVersions.length === 0) {
      return newConfig;
    }
    var latestVersion = allVersions[0];
    return AppConfigTransforms.diff(this.appVersions[latestVersion], newConfig);
  }

The 'requestAppVersion' function is called when clicking the configurations tab.

@pierrecdn
Copy link

Apparently, you need yo apply that to make it pass the travis test: 5d43f37

I'm also waiting for your patch to be applied and built into the upstream marathon.

@dave-re
Copy link
Contributor Author

dave-re commented May 31, 2016

I have done it.

@janisz
Copy link
Contributor

janisz commented Jul 15, 2016

@pierlo-upitup What's the status of this?

@aldipower
Copy link
Contributor

Hey thanx so much for taking care of this!

@aldipower aldipower merged commit 1dc20f6 into mesosphere:master Jul 25, 2016
@dave-re dave-re deleted the fix_apply_button branch July 26, 2016 14:44
@vervas
Copy link

vervas commented Oct 4, 2016

Did this make it in a released version? We are using marathon v1.1.4 and we still experience the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants