Disable restart btn for suspended apps #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @janisz, I am currently looking into your PR. Thanks in advance for contributing to marathon-ui, again. |
| @@ -68,7 +68,7 @@ var AppPageControlsComponent = React.createClass({ | |||
| onClick={this.handleScaleApp}> | |||
| Scale Application | |||
| </button> | |||
| <button className="btn btn-lg btn-default" | |||
| <button className={"btn btn-lg btn-default " + suspendAppClassSet} | |||
There was a problem hiding this comment.
I would prefer to have a specific class set for the restart button. Otherwise we may get unforeseen side effects if we ever change the suspendAppClassSet
This is what i mean:
var restartAppClassSet = classNames("btn btn-lg btn-default ", {
"disabled": props.model.instances < 1
});Otherwise I do like the idea. Thanks for this Pull Request. If you add this change I will make sure it gets merged into master asap.
janisz
force-pushed
the
disable_restart_for_suspended_apps
branch
from
28a6821
to
ec68dd7
Compare
orlandohohmeier
approved these changes
Sep 21, 2016
|
@janisz great job 💯 ✨ thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.