Containerize the development environment #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poltergeist
suggested changes
May 10, 2017
docker-compose.yml
Outdated
| - MESOS_DOCKER_STOP_TIMEOUT=60secs | ||
| - MESOS_RESOURCES=cpus:4;mem:1280;disk:25600;ports(*):[12000-12999] | ||
| marathon-service: | ||
| image: mesosphere/marathon:v1.4.0-RC5 |
There was a problem hiding this comment.
Please use :latest-dev here.
Improve the developer experience by containerizing the development environment – this is in particular helpful when switching between projects that require different node and npm versions. Changes: * Update the docker-compose to the new format (version: 2) * Add Dockerfile to build the development environment * Adjust docker-compose to build and run the development-environment * Update the documentation to reflect the changes
orlandohohmeier
force-pushed
the
feature/containerize-the-development-environment
branch
from
2d79b7b
to
385def4
Compare
Poltergeist
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the developer experience by containerizing the development environment – this is in particular helpful when switching between projects that require different node and npm versions.
Changes:
development-environment