Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx MARATHON_UI-145 and added some features #812

Closed
wants to merge 1 commit into from

Conversation

cedbossneo
Copy link

  • MARATHON_UI-145 : The initial value of acceptedResourceRoles is null so there is no justification to return an array with the default value(*).
  • Added GitHub release to travis configuration
  • Added app description if _ui_description label is present
  • Fix Endpoints uri scheme by adding a new config parameter : slavesScheme
  • Added a link to each application to easily access it (appReverseProxy)
  • Added a way to override the config at runtime by putting a file named runtimeConfig.js along with main.js :
    var runtimeConfig = {
    appReverseProxy: "http://%APP%.example.com"
    };
  • Added a launch script that configure runtimeConfig via env variables

- MARATHON_UI-145 : The initial value of acceptedResourceRoles is null so there is no justification to return an array with the default value(*).
- Add GitHub release to travis configuration
- Add app description if _ui_description label is present
- Fix Endpoints uri
- Add a link to each application to easily access it
@schneidexe
Copy link

schneidexe commented Jul 10, 2017

The thing with the * for resources is a real killer if you have exclusive slaves per framework. Even worse if there is a * marathon seems does not to accept explicit role-tied offers (e.g. slave role is services, backend, frontend, etc.)

👍 for this fix

@orlandohohmeier
Copy link
Contributor

@cedbossneo thanks a lot for taking the time to address MARATHON_UI-145! 💯👍 Could you please split your changes into separate PRs so that we can review, discuss and land the different fixes and adjustments one after another? This will help fast track the fix and makes it easier to properly review your changes.

@orlandohohmeier
Copy link
Contributor

@cedbossneo I'm sorry but I can't move this one forward as is. Please split your changes into separate PRs so that we can review, discuss and land the different fixes and adjustments one after another. Many thanks in advance!

@orlandohohmeier
Copy link
Contributor

I'm going to close this PR as I'm unable to move this one forward in it's current state. I like to stress that I'm more than happy to review the respective adjustments, changes and fixes once they're extracted into separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants