Fix data passing from plugins to DialogActions

[daltonmatos]

Hello all,

Plugins are currently unable to show any usable dialogs. Any call to

PluginHelper.callAction(PluginActions.DIALOG_ALERT, {
  title: "Hello world",
  message: "Hi, Plugin speaking here."
});

will result in a blank Alert Dialog Box. The problem seems to be on the
transformation that action.data suffers prior to be passed to
proxy.actionFunction().

With action.data being an object, in this case, {title: "...", message: "..."}, when calling actionFunction(...action.data) the result is
actionFunction([]), which creates the empty Dialog Box.

This happens because every registered actionFunction, in this case
DialogActions.{alert,insert,updatem,delete}, already has its signature
as DialogActions.<func-name>(...data).

If we prefer to leave this elipsis also on the callling side, another
way to fix is to change tha call to:

proxy.actionFunction(...[action.data]);

Let me know what you all think about this change. The code example was extracted from the example plugin, here.

[Poltergeist]

Hi @daltonmatos,

Thanks for the Pull request. I will look into the pull request in the next days.

[daltonmatos]

Thanks @Poltergeist,

Let me know what you think. Feel free to point out any adjustments.

[daltonmatos]

Hello @Poltergeist, have yo had any time to review this PR?

Thanks,

[orlandohohmeier]

@daltonmatos We're using the spread syntax to pass multiple values to actionFunction, thus you should always pass an arguments array to PluginHelper.callAction. This allows us to also proxy actions that require more than argument, but we might wanna change the property name from data to args to document the intention.

Example

PluginHelper.callAction(PluginActions.DIALOG_ALERT, [{
  title: "Hello world",
  message: "Hi, Plugin speaking here."
}]);

I just checked and have to admit that the example plugin is actually wrong. I opened a PR to address the issue and would love if you could review my changes.

mesosphere/marathon-ui-example-plugin#6

I'm going to close this PR as the change is not desired. Hope that is ok with you.

[daltonmatos]

Sure, @orlandohohmeier. Thanks for the clarifications!

I just reviewed the example-plugin code and it works as expected. This PR here does not make sense, indeed.

Thanks a lot!