Containerizer type switch when using application edit form. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The containerizer type is switching from MESOS to DOCKER when any change is done in the application edit form. It's due to the fact that the field is auto-detected by the presence of the key 'docker' in the app model. However the presence of this key is not sufficient to correctly detect the containerizer in use since Mesos containerizer can also use Docker images (so also declaring 'docker' key). I also took the opportunity to add the field in the form so that the user can switch without going through the UI.
|
Hello @wavesoft , we've been using this feature internally for a while now. It seems to be bug free. Can you please help to move forward with that PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The containerizer type is switching from MESOS to DOCKER when
any change is done in the application edit form. It's due to the fact
that the field is auto-detected by the presence of the key 'docker' in the
app model. However the presence of this key is not sufficient to correctly
detect the containerizer in use since Mesos containerizer can also use Docker
images (so also declaring 'docker' key).
I also took the opportunity to add the field in the form so that the user can
switch without going through the UI.