Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check result array [null] returned in embedded tasks sometimes #1106

Closed
sttts opened this issue Jan 27, 2015 · 3 comments
Closed

Health check result array [null] returned in embedded tasks sometimes #1106

sttts opened this issue Jan 27, 2015 · 3 comments
Assignees
Milestone

Comments

@sttts
Copy link
Contributor

sttts commented Jan 27, 2015

Might be related to #1082.

@sttts
Copy link
Contributor Author

sttts commented Jan 27, 2015

"tasks": [
            {
                "appId": "/hotel",
                "healthCheckResults": [
                    null
                ],
                "host": "192.168.2.2",
                "id": "hotel.13fa9af6-a607-11e4-b784-9a6f81a7ceff",
                "ports": [
                    32005
                ],
                "stagedAt": "2015-01-27T09:30:05.814Z",
                "startedAt": "2015-01-27T09:30:09.442Z",
                "version": "2015-01-27T09:30:00.709Z"
            }
        ],

@drexin drexin added bug and removed good first bug labels Jan 27, 2015
@drexin drexin added this to the 0.8.0 milestone Jan 27, 2015
@drexin drexin self-assigned this Jan 27, 2015
@drexin drexin modified the milestones: 0.8.1, 0.8.0 Jan 30, 2015
@drexin
Copy link
Contributor

drexin commented Jan 30, 2015

Moved to 0.8.1, as this is not critical.

@bobrik
Copy link
Contributor

bobrik commented Feb 9, 2015

null resulted in health check that was alive: false in our service discovery. This is probably still related to #1082. alive: false is not bad per se, it's bad because previous task was killed before the new one became healthy.

Transition:

[
  {
    "id": "totally_different_path.361e84d1-b041-11e4-bc81-56847afe9799",
    "host": "web33",
    "ports": [
      31005
    ],
    "startedAt": "2015-02-09T09:52:12.080Z",
    "stagedAt": "2015-02-09T09:51:25.529Z",
    "version": "2015-02-09T09:51:20.692Z",
    "appId": "/totally/different/path"
  }
]
[
  {
    "id": "totally_different_path.361e84d1-b041-11e4-bc81-56847afe9799",
    "host": "web33",
    "ports": [
      31005
    ],
    "startedAt": "2015-02-09T09:52:12.080Z",
    "stagedAt": "2015-02-09T09:51:25.529Z",
    "version": "2015-02-09T09:51:20.692Z",
    "appId": "/totally/different/path",
    "healthCheckResults": [
      null
    ]
  }
]
[
  {
    "id": "totally_different_path.361e84d1-b041-11e4-bc81-56847afe9799",
    "host": "web33",
    "ports": [
      31005
    ],
    "startedAt": "2015-02-09T09:52:12.080Z",
    "stagedAt": "2015-02-09T09:51:25.529Z",
    "version": "2015-02-09T09:51:20.692Z",
    "appId": "/totally/different/path",
    "healthCheckResults": [
      {
        "alive": true,
        "consecutiveFailures": 0,
        "firstSuccess": "2015-02-09T09:54:41.307Z",
        "lastFailure": null,
        "lastSuccess": "2015-02-09T09:54:41.307Z",
        "taskId": "totally_different_path.361e84d1-b041-11e4-bc81-56847afe9799"
      }
    ]
  }
]

@drexin drexin modified the milestones: 0.8.1, 0.8.2 Feb 24, 2015
@drexin drexin closed this as completed in 3f1eabe Mar 27, 2015
kolloch pushed a commit that referenced this issue Mar 27, 2015
fixes #1106 - Return empty HealthCheck result instead of None, when no r...
kolloch pushed a commit that referenced this issue Mar 27, 2015
8e30672
Merge: 6f1aff3 3ec8f59
Author: Peter Kolloch <peter@mesosphere.com>
Date:   Fri Mar 27 16:07:26 2015 +0100

    Merge pull request #1107 from mesosphere/wip-1106-drexin

    fixes #1106 - Return empty HealthCheck result instead of None, when no r...
kolloch pushed a commit that referenced this issue Mar 27, 2015
commit 8e30672
Merge: 6f1aff3 3ec8f59
Author: Peter Kolloch <peter@mesosphere.com>
Date:   Fri Mar 27 16:07:26 2015 +0100

    Merge pull request #1107 from mesosphere/wip-1106-drexin

    fixes #1106 - Return empty HealthCheck result instead of None, when no r...
@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants