Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report kills due to failed health check in "Last Task Failure" #3423

Closed
bobrik opened this issue Mar 8, 2016 · 1 comment
Closed

Report kills due to failed health check in "Last Task Failure" #3423

bobrik opened this issue Mar 8, 2016 · 1 comment

Comments

@bobrik
Copy link
Contributor

bobrik commented Mar 8, 2016

Currently (v0.15.3) Marathon can kill task due to failed health check, but it doesn't show up in "Last Task Failure" in debug tab. I propose reporting kills as task failures and showing them in debug tab.
@aquamatthias
Copy link
Contributor

The current health check logic is pretty isolated and initiates a task kill, if a task becomes unhealthy.
Since from that side it is not a task failure (as reported by mesos) we do not add this information.
I agree we should add this information.

@aquamatthias aquamatthias added this to the Backlog milestone Mar 9, 2016
janisz added a commit to janisz/marathon that referenced this issue Mar 16, 2016
@janisz
Fixes mesosphere#3423 | Report kills due to failed healthcheck.
91fc621 
Healthcheck kills are published as an event and stored as task failure.
They appear in UI showing cause of last failed health check and host
just as noraml Mesos task failures.
janisz added a commit to janisz/marathon that referenced this issue Mar 17, 2016
@janisz
Fixes mesosphere#3423 | Report kills due to failed healthcheck.
ba8db3c 
Healthcheck kills are published as an event and stored as task failure.
They appear in UI showing cause of last failed health check and host
just as noraml Mesos task failures.
janisz added a commit to janisz/marathon that referenced this issue Mar 21, 2016
@janisz
Fixes mesosphere#3423 | Report kills due to failed healthcheck.
2c487c5 
Healthcheck kills are published as an event and stored as task failure.
They appear in UI showing cause of last failed health check and host
just as noraml Mesos task failures.
janisz added a commit to janisz/marathon that referenced this issue Mar 21, 2016
@janisz
Fixes mesosphere#3423 | Report kills due to failed healthcheck.
bd197bf 
Healthcheck kills are published as an event and stored as task failure.
They appear in UI showing cause of last failed health check and host
just as noraml Mesos task failures.
aquamatthias added a commit that referenced this issue Mar 21, 2016
@aquamatthias
Merge pull request #3512 from janisz/show_unhealthy_as_a_failure
82ee7dd 
Fixes #3423 | Report kills due to failed healthcheck.
@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobrik @aquamatthias