Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marathon fails to release reserved resources for deleted apps #5142

Closed
timcharper opened this issue Feb 8, 2017 · 1 comment
Closed

Marathon fails to release reserved resources for deleted apps #5142

timcharper opened this issue Feb 8, 2017 · 1 comment
Assignees
@timcharper

Comments

@timcharper
Copy link
Contributor

timcharper commented Feb 8, 2017 •
edited

As of this writing, with the head of e62695b, I've encountered a case in which Marathon cannot release reserved resources because they are identified as spurious, which results in a force expunge. Down the line, the [force expunge fails because the app does not exist].

Expunge should probably be made idempotent, such that if it doesn't exist, then the result is successful.
timcharper pushed a commit that referenced this issue Feb 9, 2017
ForceExpunge for missing task is a no-op, rather than a failure
5460a74 
Summary: Address #5142

Test Plan: add tests

Reviewers: jasongilanfarr, meichstedt

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D498
@aquamatthias aquamatthias mentioned this issue Feb 9, 2017
Closed
@aquamatthias
Copy link
Contributor

I agree - the same logic as rm -f, which does not give you an error, if it is already deleted.

@timcharper timcharper mentioned this issue Feb 9, 2017
Closed
6 tasks
This was referenced Feb 22, 2017
Closed
Closed
timcharper pushed a commit that referenced this issue Feb 23, 2017
ForceExpunge for missing task is a no-op, rather than a failure
2b2b0e4 
Summary:
If a resident app is deleted before Marathon has a chance to
release the associated resources, then later attempts to release them
fail because because we ForceExpunge the task-ID when processing our
UnreserveAndDestroyVolumes operation.

This change makes ForceExpunge for a non-existent task respond with
no-op, rather than failure.

Fixes #5142

Backport of f441c57

Test Plan: n/a

Reviewers: jasongilanfarr, meichstedt

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D547
@timcharper timcharper mentioned this issue Feb 23, 2017
Merged
@timcharper timcharper self-assigned this Feb 23, 2017
timcharper pushed a commit that referenced this issue Feb 23, 2017
@timcharper
ForceExpunge for missing task is a no-op, rather than a failure
ec4b044 
Summary:
If a resident app is deleted before Marathon has a chance to
release the associated resources, then later attempts to release them
fail because because we ForceExpunge the task-ID when processing our
UnreserveAndDestroyVolumes operation.

This change makes ForceExpunge for a non-existent task respond with
no-op, rather than failure.

Fixes #5142

Backport of f441c57

Test Plan: n/a

Reviewers: jasongilanfarr, meichstedt

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D547
@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timcharper timcharper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timcharper @aquamatthias