fixed wrong gc calculation

[unterstein]

Before the task state refactoring the class ExpungeOverdueLostTasksActor had following logic to filter unreachable tasks which received 24 hours no updates:

  def filterLostGCTasks(tasks: Map[PathId, AppTasks]): Iterable[Task] = {
    def isTimedOut(task: Task): Boolean = {
      task.mesosStatus.fold(false) { status =>
        val age = clock.now().toDateTime.minus(status.getTimestamp.toLong * 1000).getMillis.millis
        age > config.taskLostExpungeGC
      }
    }
    tasks.values.flatMap(_.tasks.filter {
      case TemporarilyUnreachable(task) if isTimedOut(task) => true
      case _ => false
    })
  }

During the refactoring the filter was changed to

tasks.values.flatMap(_.tasks.filter(task => isTimedOut(task.mesosStatus)))

which misses the fact that it should filter the unreachable tasks, which I re-introduced with this PR by adding task => task.isUnreachable && isTimedOut(task.mesosStatus)

[gkleiman]

times(1) is the default, so this is redundant, but ok if you want to be very explicit =)

[unterstein]

Ah ok, did`t know that. Should I change this?

[jasongilanfarr]

I actually like it personally.

verify(mock).abc()vs verify(mock, once).abc() is much more obvious.

[gkleiman]

LGTM, I guess that we need to cherry-pick this, so a changelog entry would be nice =)

[kensipe]

LGTM after the style updates.

[gkleiman]

Thanks for fixing this nasty bug!