Include TASK_FINISHED as failure state when upgrading #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Issue #4866 |
zen-dog
suggested changes
Dec 21, 2016
| @@ -138,7 +138,7 @@ object TaskReplaceActor { | |||
| private[this] val log = LoggerFactory.getLogger(getClass) | |||
|
|
|||
| val KillComplete = "^TASK_(ERROR|FAILED|FINISHED|LOST|KILLED)$".r | |||
There was a problem hiding this comment.
Since KillComplete and FailedToStart are now equal, I would use one and call it smth. like IsTerminal.
If we upgrade an app with health check, and newly launched task finished before passing health check, the current task replace actor ignore this TASK_FINISHED message and run into a strange state: 1. it waits for task status update event, but it won't get any; 2. it won't try to launch a new task.
fengyehong
force-pushed
the
releases/1.3
branch
from
130bc0e
to
72e2151
Compare
|
updated, replace FailedToStart and KillComplete with IsTerminal |
zen-dog
approved these changes
Dec 22, 2016
|
ok to test |
|
test this please |
|
retest this please |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we upgrade an app with health check, and newly launched task
finished before passing health check, the current task replace actor
ignore this TASK_FINISHED message and run into a strange state: