Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote some vars and make sed more explicit #4890

Merged
merged 1 commit into from Dec 20, 2016
Merged

Quote some vars and make sed more explicit #4890

merged 1 commit into from Dec 20, 2016

Conversation

lloesche
Copy link
Contributor

This fixes an issue introduced in 3b10a8e
where default_accepted_resource_roles=* will not be processed correctly.

The shell will expand * into all the files in the current directory if not contained in double quotes.

User report #4854

I also added quotes to some other obvious places.

@review-ninja
Copy link

ReviewNinja

@unterstein unterstein mentioned this pull request Dec 20, 2016
Closed
@unterstein
Copy link
Contributor

Fixes #4854

This was referenced Dec 20, 2016
Closed
Closed
@aquamatthias
Copy link
Contributor

Thanks!

@unterstein
Copy link
Contributor

retest this please

@unterstein
Copy link
Contributor

Thanks!

    .  o ..                  
     o . o o.o                
          ...oo               
            __[]__          Shippin'  
         __|_o_o_o\__         it!
         \""""""""""/         
          \. ..  . /          
     ^^^^^^^^^^^^^^^^^^^^

@unterstein unterstein merged commit 3a5c5b8 into master Dec 20, 2016
@unterstein unterstein deleted the lloesche/fixstartup branch December 20, 2016 16:24
aquamatthias pushed a commit that referenced this pull request Dec 21, 2016
@lloesche @aquamatthias
Quote some vars and make sed more explicit (#4890)
81ca214 
(cherry picked from commit 3a5c5b8)
@aquamatthias aquamatthias mentioned this pull request Dec 21, 2016
Merged
5 tasks
unterstein pushed a commit that referenced this pull request Jan 18, 2017
@lloesche @unterstein
Quote some vars and make sed more explicit (#4890)
fb4aeb9
@janisz janisz mentioned this pull request Jan 18, 2017
Closed
@marcomonaco marcomonaco added the pr label Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@meichstedt meichstedt meichstedt approved these changes

@unterstein unterstein unterstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lloesche @review-ninja @unterstein @aquamatthias @meichstedt @marcomonaco