New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map tcp,udp
to udp,tcp
during migration. (#6827)
#6855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm building your change at jenkins-marathon-pipelines-PR-6855-1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✗ Build of #6855 failed.
See the logs and test results for details.
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm building your change at jenkins-marathon-pipelines-PR-6855-2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Build of #6855 completed successfully.
See details at jenkins-marathon-pipelines-PR-6855-2.
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
"url": "https://s3.amazonaws.com/downloads.mesosphere.io/marathon/builds/1.7.213-c318814e9/marathon-1.7.213-c318814e9.tgz",
"sha1": "3dca6b952baa2dbf1f0c8eaaaef12f3cf05591ce"
You can run system integration test changes of this PR against Marathon master:
The job will report back to this PR.
\\ ٩( ᐛ )و //
Summary:
Marathon 1.4 would accept
tcp,udp
as a protocol in Docker portmappings. However, that value is illegal. It breaks migrations to 1.5
and up. This patch will fix the migration.
Forward port of #6827.
JIRA issues: MARATHON-8575