Quick implementation of container IP records #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sttts
commented
Aug 10, 2015
sttts
commented
- SRV records according to Add container ip label MesosContainerizer.NetworkSettings.IPAddress and remove _container prefix #197 (comment) and https://docs.google.com/spreadsheets/d/1fZcaUP2Y-MQluMl-JP_PDB1Qlg6Ad36OdSQKBj_zlu4/edit#gid=0
- remove _container prefix and add slave.mesos A records instead for the non-container IP.
|
/cc @tsenart for early review |
sttts
changed the title
| target := canonical + tail + ":" + strconv.Itoa(port.Number) | ||
|
|
||
| // use protocol if defined, fallback to tcp+udp | ||
| if port.Protocol != "" { |
There was a problem hiding this comment.
should we attempt to sanitize the port.Protocol label before splicing it in?
The old validation code expanded resolvers, then checked for duplicates. This reverts commit 21c43d0.
|
@jdef: Why did you add the WIP label? Planning to do some work on it? |
|
@tsenart yes, I'm going to update docs for A and SRV records |
|
👍 |
| HTTPOn: true, | ||
| ExternalOn: true, | ||
| RecurseOn: true, | ||
| IPSources: []string{"docker", "mesos", "host"}, |
There was a problem hiding this comment.
the default should not include "docker" since Docker, by default, uses IPs that are not cluster routable
jdef
added a commit
that referenced
this pull request
Aug 10, 2015
Quick implementation of container IP records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.