Removal of SyncConsumer, added synchronization between consumers in BaseFilter class #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Try<Nothing> _consume(const T& in) { | ||
| newProductForConsumption(); | ||
| // let derived class consume the product | ||
| Try<Nothing> result = consume(in); |
There was a problem hiding this comment.
Can we store the products in the consumer itself (append to list of products)?
|
LGTM! Great job. (: Please add some diagram of inheritance in our doc |
| * Every component should produce all it's products in the iteration. | ||
| * Components must not throw exceptions. | ||
|
|
||
| ## Pipeline |
There was a problem hiding this comment.
What do you plan to have here?
There was a problem hiding this comment.
Here we should put some considerations for Serenity developers.
skonefal
changed the title
| Contentions()); | ||
| return Nothing(); | ||
| produceResults(corrections.get(), Contentions()); | ||
| return; |
…136_remove_syncConsumer
| // this->reset(); | ||
| // If allProductsReady didn't produced all products - log error. | ||
| if (notAllProductsProduced()) { | ||
| // TODO(skonefal): Make '<<' virutal, so we could log component name. |
|
Good job, small nits and we are good to go! |
This was referenced Feb 9, 2016
Signed-off-by: bplotka <bwplotka@gmail.com>
Signed-off-by: bplotka <bwplotka@gmail.com>
Removed reason of build error in gcc 4.8.4
bwplotka
added a commit
that referenced
this pull request
Feb 11, 2016
Removal of SyncConsumer, added synchronization between consumers in BaseFilter class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.
Added virtually inherited class above Consumers and Producers to add synchronization barrier.
Serenity framework is now hardened.
In each "addConsumer" function, the consumer is informed that it will receive objects from producer.
In each "consume" event, FilterBase counts number of products that has came from producers, and when this number is equals to number of expected products - allProductsReady() function is invoked. In the end, cleanup() function is invoked.
In each producer constructor we now count number of products that should be produced in each iteration. Pipeline must go forward.
Removal of SyncConsumer class. It's functionality is not inside Consumer.