Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmarshal error for recipient on i386 #19

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

kostkobv
Copy link
Contributor

Most of the phone numbers (11 numbers) would throw an error during unmarshaling the response from the REST API, due to int would be only 32-bits long on i386 and 32-bits int is < 2,147,483,647 (10 numbers). This small fix would remove this inconvenience

@cooldarkdryplace
Copy link
Contributor

cooldarkdryplace commented Oct 31, 2017

Hey, thanks for your PR.
You are right MSISDN can overflow int32.

The ITU-T recommendation E.164 limits the maximum length of an MSISDN to 15 digits.

This is a breaking change, so we are going to include your fix in new release.

@kostkobv
Copy link
Contributor Author

@cooldarkdryplace Cheers! See you on the next Golang meetup 😉

@epels epels added the bug label Jul 16, 2018
@epels epels modified the milestones: v2.0.0, v5.0.0 Jul 16, 2018
@epels
Copy link
Contributor

epels commented Jul 17, 2018

Hi @kostkobv - thanks a bunch for your much appreciated contribution!

We're planning on releasing the new version next week. Could you please change the target branch to v5_staging? We're making a few more changes, and it's easiest for me to have them all on a single branch before releasing. Thanks in advance!

@kostkobv kostkobv changed the base branch from master to v5_staging July 17, 2018 08:51
@epels epels merged commit 2eed9fe into messagebird:v5_staging Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants